search

gardener / autoscaler

Customised fork of cluster-autoscaler to support machine-controller-manager
Apache License 2.0
16 stars 25 forks source link

Add options to `NodeGroupAutoscalingOptions` from `machineDeployment` annotations #257

Closed aaronfern closed 11 months ago

aaronfern commented 1 year ago

What this PR does / why we need it: This PR updated the machineDeployment.GetOptions() method to read annotations form machineDeployments and populate node group values in its NodeGroupAutoscalingOptions struct

Which issue(s) this PR fixes: Fixes partially #240

Special notes for your reviewer:

Release note:

Autoscaler will now add NodeGroupAutoscalingOptions to node groups from annotations present in its corresponding machineDeployments
gardener-robot commented 1 year ago

@unmarshall, @himanshu-kun, @rishabh-11 You have pull request review open invite, please check

gardener-robot commented 12 months ago

@aaronfern You need rebase this pull request with latest master branch. Please check.