Closed rishabh-11 closed 1 month ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 15 committers have signed the CLA.
:white_check_mark: rishabh-11
:x: k8s-ci-robot
:x: MaciekPytel
:x: kdw174
:x: Silvest89
:x: gjtempleton
:x: vadasambar
:x: Shubham82
:x: BigDarkClown
:x: damikag
:x: maksim-paskal
:x: apricote
:x: wenxuan0923
:x: x13n
:x: kmsarabu
You have signed the CLA already but the status is still pending? Let us recheck it.
Do we not update SYNC-CHANGES with patch versions?
It is not needed IMO as the sync changes are for minor and not patch versions.
Can you please update the docstring of machine_cloud_provider.GetOptions to the new docstring here
The docstring is part of 1.30 and is also not present upstream. I think it is fine for us to keep it like this.
I think it is fine for us to keep it like this
Okay, fair enough for me then
What this PR does / why we need it:
Which issue(s) this PR fixes: Fixes #326
Special notes for your reviewer: IT pass for AWS
Release note: