gardener / etcd-backup-restore

Collection of components to backup and restore the etcd of a Kubernetes cluster.
Apache License 2.0
289 stars 100 forks source link

[Feature] Enable KIND based integration tests through Prow jobs #429

Open timuthy opened 2 years ago

timuthy commented 2 years ago

Feature (What you would like to be added): Integration tests for this repository should be executed with the testrunner (see here) in a KIND cluster through Prow jobs. IaaS credentials which are required by the tests shall be obtained from Secrets residing in prow cluster instead of using cc-config (ref).

Motivation (Why is this needed?): Fetching IaaS credentials via cc-config (ref) will be discontinued.

cc @shreyas-s-rao @mliepold @hendrikKahl

timuthy commented 2 years ago

This requirement can only be implemented when fully supported by test machinery.

ashwani2k commented 1 year ago

@abdasgupta -- This is done right can we close this issue then.

shreyas-s-rao commented 1 year ago

@ashwani2k not yet, etcd-backup-restore cluster-based integration tests are still not run in KIND clusters, but rather need to be manually run today using make integration-test-cluster, and not even run as part of CI pipeline due to an issue with obtaining credentials for the tests. It was decided that rather than running these tests on concourse, they can be run on a KIND cluster with the help of Prow. Now that etcd-druid e2e tests are run automatically upon every druid PR and release using prow and localstack, avoiding the need to use real-world AWS credentials, similar setup can be used by etcd-backup-restore cluster-based integration tests as well. WDYT?

/cc @abdasgupta

Note: this has nothing to do with the regular integration tests for etcd-backup-restore that are run today as part of CI pipeline for PRs as well as releases, which runs etcd and etcdbrctl as separate processes rather than as a statefulset in a k8s cluster.