search

gardener / etcd-backup-restore

Collection of components to backup and restore the etcd of a Kubernetes cluster.
Apache License 2.0
288 stars 100 forks source link

Set appropriate SSE Customer Key and MD5 in `S3SnapStore.uploadPart()` for SSE-C #728

Closed amold1 closed 6 months ago

amold1 commented 6 months ago

What this PR does / why we need it: This is mostly a typo bug from the previous sse PR

gardener-robot commented 6 months ago

@amold1 Thank you for your contribution.

gardener-robot-ci-3 commented 6 months ago

Thank you @amold1 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

renormalize commented 6 months ago

@amold1 thanks.

amold1 commented 6 months ago

Can't believe I missed this in #719.

I was mainly focusing on avoiding regressions with this feature addition, as it relates to backups and not being able to read backups is the worst thing that could happen.

Hadn't tested with a custom key for the final few commits since things were looking fine.

No worries... we've all been there. Thanks for merging this.

On a related note, when would this feature be available for use? Any release timelines you might be aware of?

renormalize commented 6 months ago

There is no timeline currently for the next release, not too many features have been added since the last release.

You could always host a build at this commit in your registry.