search

gardener / etcd-backup-restore

Collection of components to backup and restore the etcd of a Kubernetes cluster.
Apache License 2.0
287 stars 100 forks source link

[rel-v0.28] Full snapshot lease update retry on failure #747

Closed anveshreddy18 closed 4 months ago

anveshreddy18 commented 4 months ago

What this PR does / why we need it:

cherry-pick of PR #711, #720, and #744 combined together

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

Introduce periodic updates to the Full Snapshot Lease, addressing delays in lease updates during failures
anveshreddy18 commented 4 months ago

@renormalize Out of these three PR's, the first one contains most of the functionality and since the other two PR's were just reverts and don't add anything, it was advised by @ishan16696 to not add those commits. But I agree it would make the reviewer's life easier in general, but in this case, since these are reverts, I didn't want to include them as commits. I hope this is fine.

ishan16696 commented 4 months ago

Out of these three PR's, the first one contains most of the functionality and since the other two PR's were just reverts and don't add anything, it was advised by @ishan16696 to not add those commits

Just 1 nit-pick, this PR can be splitted into 2 commits. 1 commit for cherry-pick and another commit for all reverts on top of that cherry-pick. May be I wasn't able to convey it properly. Anyway it look good.

ashwani2k commented 4 months ago

Tested the scenario and it tries to renew the full snapshot lease every 1 min now. We can merge this one.