gardener / etcd-backup-restore

Collection of components to backup and restore the etcd of a Kubernetes cluster.
Apache License 2.0
284 stars 99 forks source link

Fix the registry link #758

Closed renormalize closed 1 month ago

renormalize commented 1 month ago

What this PR does / why we need it:

Registry link of etcd-backup-restore is different from what is currently being used in etcd-druid, and this makes development of etcd-backup-restore while using it in etcd-druid slightly painful. Fixing the link here in etcd-backup-restore makes development smoother.

kind load operations would be made easier since etcd-druid expects europe-docker.pkg.dev/gardener-project/public and the built image of etcd-backup-restore has europe-docker.pkg.dev/gardener-project/snapshots.

Release note:

Registry link changed to match the one used elsewhere during development in the gardener org.
ishan16696 commented 1 month ago

I tried to push a image with your changes but it failed as public is a virtual repository, so we can't do push to public repo as it's virtual.

The push refers to repository [europe-docker.pkg.dev/gardener-project/public/gardener/etcdbrctl]
a9b81b9d1d28: Retrying in 1 second
2388d21e8e2b: Layer already exists
c048279a7d9f: Layer already exists
1a73b54f556b: Layer already exists
2a92d6ac9e4f: Layer already exists
bbb6cacb8c82: Layer already exists
ac805962e479: Layer already exists
af5aa97ebe6c: Layer already exists
4d049f83d9cf: Layer already exists
9ed498e122b2: Layer already exists
577c8ee06f39: Layer already exists
c656415fb81c: Layer already exists
name invalid: "Write" operation not supported for "VIRTUAL_REPOSITORY"
make: *** [docker-push] Error 1

Registry link of etcd-backup-restore is different from what is currently being used in etcd-druid

etcd-druid also targeting the same repo: https://github.com/gardener/etcd-druid/blob/master/Makefile#L9-L10

ishan16696 commented 1 month ago

As discussed with @renormalize this PR is not required due to this https://github.com/gardener/etcd-backup-restore/pull/758#issuecomment-2283434596. Hence closing this PR. /close

gardener-robot commented 1 month ago

@ishan16696 Branch registry has been deleted.