search

gardener / etcd-backup-restore

Collection of components to backup and restore the etcd of a Kubernetes cluster.
Apache License 2.0
289 stars 100 forks source link

Minimise the impact of flaky unit tests in the `defragmentor` pkg by making it fail fast #799

Closed anveshreddy18 closed 1 week ago

anveshreddy18 commented 1 week ago

What this PR does / why we need it:

This PR attempts to run the pkg/defragmentor unit test pkg before running remaining packages, this is done to reduce the waiting time to see the error & for retrying tests in case of a flaky test failure in the defragmentor suite. With the randomisation of test suites in the current setup, this flaky test could end up running near the end and failing. This only causes delays in review or getting the PR merged as the tests take decent amount of time to run.

Which issue(s) this PR fixes: Fixes #798

Special notes for your reviewer:

This is just a dirty fix for now, a proper solution would be to fix the flaky tests. We can remove this extra handling once that gets fixed.

Release note:

None
renormalize commented 1 week ago

@anveshreddy18 feel free to merge this whenever you have the time.

ishan16696 commented 1 week ago

no need to add a release note for this PR.

anveshreddy18 commented 1 week ago

no need to add a release note for this PR.

Sure, removed it.