search

gardener / etcd-druid

An etcd operator to configure, provision, reconcile and monitor etcd clusters.
Apache License 2.0
74 stars 50 forks source link

[Upgrade] Move the etcd from `v3.4.26` to `v3.4.34` to `v3.5.x` #445

Open ishan16696 opened 2 years ago

ishan16696 commented 2 years ago

Feature (What you would like to be added): Upgrade the etcd from v3.4.26 to v3.5.x.

Motivation (Why is this needed?): We are missing many fixes which comes only in latest version of etcd 3.5.x. eg:

  1. https://github.com/etcd-io/etcd/pull/14400
  2. https://github.com/etcd-io/etcd/pull/12410
  3. https://github.com/etcd-io/etcd/pull/13399 and many more

The upgrade will be completed stepwise:

Approach/Hint to the implement solution (optional): We haven't decided to which exact version we want to move. We have to find the stable version of etcd v3.5.x which is good for production use with very less or none severe issues reported on upstream.

ishan16696 commented 1 year ago

/assign

abdasgupta commented 1 year ago

Any progress to this? Did we find which ETCD version to use?

ishan16696 commented 1 year ago

no update from my side as I'm busy with refactoring. Anybody can this over. /unassign

ishan16696 commented 1 year ago

This issue of moving the custom-etcd image: https://github.com/gardener/etcd-custom-image/issues/16 to golang app requires latest etcd v3.5.x, Hence this is dependent on etcd version upgrade to take advantage of various functionality like EtcdServer.leaderChangedNotify. IMO, we have to increase the priority of this issue.

shreyas-s-rao commented 9 months ago

In an out-of-band discussion with @ishan16696 @unmarshall @ashwani2k @abdasgupta , we decided that this change cannot be clubbed with the release of etcd-steward (as previously thought of). This change requires a dedicated release of etcdbr+druid, so that the change is deterministic, and no other changes are clubbed with it.

ialidzhikov commented 1 month ago

This is also important for Kubernetes 1.31: see https://github.com/gardener/etcd-wrapper/issues/28

renormalize commented 3 weeks ago

We've decided to move to the latest patch, v3.4.34. I've started work on this. Work will be tracked here https://github.com/gardener/etcd-backup-restore/issues/792.