Compaction job shouldn't add `cluster-autoscaler.kubernetes.io/safe-to-evict: "false"` annotation to compaction pod.

gardener / etcd-druid

An etcd operator to configure, provision, reconcile and monitor etcd clusters.

Apache License 2.0

70 stars 49 forks source link

Compaction job shouldn't add `cluster-autoscaler.kubernetes.io/safe-to-evict: "false"` annotation to compaction pod. #845

Closed ishan16696 closed 1 month ago

ishan16696 commented 2 months ago

/area cost /kind enhancement

What this PR does / why we need it: Right now, compaction job adds all annotation(s) present in etcd custom resource spec to compaction pod template. With this PR, compaction will not add annotation: cluster-autoscaler.kubernetes.io/safe-to-evict: "false" to compaction pod if its present to improve node utilization.

Which issue(s) this PR fixes: Fixes Point1 of #766

Special notes for your reviewer:

Release note:

To improve node utilization compaction job will not add annotation: `cluster-autoscaler.kubernetes.io/safe-to-evict: "false"` to compaction pod.

ishan16696 commented 2 months ago

/retest

ishan16696 commented 2 months ago

/test pull-etcd-druid-e2e-kind

ishan16696 commented 2 months ago

/retest

ishan16696 commented 2 months ago

/test pull-etcd-druid-e2e-kind

ishan16696 commented 2 months ago

/test pull-etcd-druid-e2e-kind

renormalize commented 2 months ago

Also, @ishan16696; using "Fixes #" would automatically close that issue when this PR merges. Maybe you can mention the issue number in the PR description instead of the "Fixes:" section. Thanks!

ishan16696 commented 2 months ago

Also, @ishan16696; using "Fixes #" would automatically close that issue when this PR merges.

I will re-open it, if it closes ... not a bigger thing 😅

shreyas-s-rao commented 1 month ago

/needs cherry-pick As discussed, to be cherry-picked to hotfix-v0.28 branch.