search

gardener / etcd-druid

An etcd operator to configure, provision, reconcile and monitor etcd clusters.
https://gardener.github.io/etcd-druid/
Apache License 2.0
77 stars 50 forks source link

Wrong annotations in Quorum loss doc #858

Closed StenlyTU closed 3 months ago

StenlyTU commented 3 months ago

How to categorize this issue?

/area quality /kind question

What happened:

I've recently had to restore ETCD from Quorum loss following the guide under .docs/operations/recovery-from-permanent-quorum-loss-in-etcd-cluster.md and the annotations under point 1 didn't prevent reconciliation.

kubectl annotate etcd etcd-main druid.gardener.cloud/suspend-etcd-spec-reconcile=

kubectl annotate etcd etcd-main druid.gardener.cloud/disable-resource-protection=

In previous revision of the file the annotation etcd-main druid.gardener.cloud/ignore-reconciliation="true" worked as expected.

@unmarshall Can you check? cc @adenitiu

What you expected to happen:

The annotations to prevent reconciliation

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

renormalize commented 3 months ago

@StenlyTU Quite a bit of refactoring has happened in etcd-druid, and the current doc on master refers to the newer annotation which hasn't yet been released.

I guess checking out the release tag 0.22.x which is running and following the doc present in that commit would currently fix your issue.

ishan16696 commented 3 months ago

Hi @StenlyTU , As I mentioned in the issue, for our landscapes we have to use this doc: https://github.com/gardener/etcd-druid/blob/hotfix-v0.22/docs/operations/recovery-from-permanent-quorum-loss-in-etcd-cluster.md as in our landscapes we are using druid v0.22.4. Things have changed for master branch as mentioned in this comment: https://github.com/gardener/etcd-druid/issues/858#issuecomment-2290899703 Closing this issue. /close