search

gardener / external-dns-management

Environment to manage external DNS entries for a kubernetes cluster
Apache License 2.0
81 stars 67 forks source link

Update Cloudflare README.md to remove information about base64-encoding #361

Closed SeanKilleen closed 6 months ago

SeanKilleen commented 6 months ago

What this PR does / why we need it: The documentation for the secret is wrong and those following it will not be able to set up external DNS management for Cloudflare.

Which issue(s) this PR fixes: Fixes #360

Special notes for your reviewer: I fixed a typo as well. Also, I want to be sure my issue #360 is validated prior to merging this to ensure I don't screw things up.

Release note:

Revised Cloudflare External DNS Management document to no longer recommend base64 encoding of the token in the secret.
CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

gardener-robot commented 6 months ago

@SeanKilleen Thank you for your contribution.

gardener-robot-ci-2 commented 6 months ago

Thank you @SeanKilleen for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

MartinWeindel commented 6 months ago

/cla

MartinWeindel commented 6 months ago

@SeanKilleen Can you please sign the CLA? See https://github.com/gardener/external-dns-management/pull/361#issuecomment-2008099269

gardener-robot commented 6 months ago

@MartinWeindel I reached out successfully to the cla-assistant to recheck this pull request.

SeanKilleen commented 6 months ago

@MartinWeindel I think that's the best of all worlds. Makes sense to me. Thanks! CLA signed.