Merge /pkg/flags into /pkg/target

gardener / gardenctl-v2

Command-line client for the Gardener with focus on operations

Apache License 2.0

29 stars 20 forks source link

Merge /pkg/flags into /pkg/target #296

Open petersutter opened 1 year ago

petersutter commented 1 year ago

What would you like to be added: Merge /pkg/flags into /pkg/target and rename target.go (within /pkg/flags) to flags.go Also drop the unsued parameter from func RegisterCompletionFuncsForTargetFlags(cmd *cobra.Command, factory util.Factory, ioStreams util.IOStreams, _ *pflag.FlagSet) {

Why is this needed:

petersutter commented 1 year ago

/hold currently this would result in an import cycle:

pkg/target/flags.go depends on -> internal/util (Factory, IOStreams) depends on -> pkg/target (Manager, TargetFlags)