gardener / gardener-extension-networking-cilium

Gardener extension controller for the Cilium CNI network plugin.
https://gardener.cloud
Apache License 2.0
13 stars 38 forks source link

Allow setting loopback as direct routing device in Cilium 1.15+ #314

Closed robertvolkmann closed 4 months ago

robertvolkmann commented 4 months ago

How to categorize this PR? /area networking /kind api-change

What this PR does / why we need it: Since Cilium 1.15, the loopback device will be no longer autodetected as direct routing device and has to be manually configured. https://github.com/cilium/cilium/issues/30889 https://github.com/cilium/cilium/pull/31200

Special notes for your reviewer:

gardener-prow[bot] commented 4 months ago

Hi @robertvolkmann. Thanks for your PR.

I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
gardener-robot commented 4 months ago

@robertvolkmann Thank you for your contribution.

gardener-robot-ci-3 commented 4 months ago

Thank you @robertvolkmann for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

axel7born commented 4 months ago

/ok-to-test

axel7born commented 4 months ago

The change looks good in general. Only, I would formulate the comment a bit different.

axel7born commented 4 months ago

/lgtm