search

gardener / gardener-extension-os-coreos

Gardener extension controller for the CoreOS/FlatCar Container Linux operating system.
https://gardener.cloud
Apache License 2.0
4 stars 31 forks source link

[release-v1.21] Fix filepath collection for files with `ImageRef` #103

Closed nitrocb closed 7 months ago

nitrocb commented 7 months ago

/area os /kind bug

What this PR does / why we need it:

When the Gardener Node Agent for worker nodes is activated, either using the appropriate featuregate or using Gardener version v1.89.0 and above, the OperatingSystemConfig introduces some changes. One of these changes is, that files can now have a imageRef field. When this field is present, the file is extracted from a container image and not presented inline.

The reconcile is running into a panic in case of files with an imageRef field, because its trying to extract the inline data. This small fix simply skips the content collection for these kind of files.

Release note:

Skipping filecontent collection for files with imageRef in OperatingSystemConfigs to prevent a panic.
nitrocb commented 7 months ago

@timebertt

gardener-robot commented 7 months ago

@nitrocb Thank you for your contribution.

gardener-robot commented 7 months ago

@timebertt, @dergeberl You have pull request review open invite, please check