gardener / gardener-extension-os-coreos

Gardener extension controller for the CoreOS/FlatCar Container Linux operating system.
https://gardener.cloud
Apache License 2.0
4 stars 31 forks source link

Compatibility with logrotate in /usr/bin #56

Closed lukasgr90 closed 1 year ago

lukasgr90 commented 1 year ago

How to categorize this PR?

/area os /kind bug

What this PR does / why we need it:

Recent flatcar images has the logrotate binary not in /usr/sbin anymore, but in /usr/bin. Thus this PR extends the run-command.service (doing Containerd & Flatcar / Core OS related patches) to check for the alternate location of logrotate. If it finds the binary under /usr/bin it patches the path in /etc/systemd/system/containerd-logrotate.service.

Which issue(s) this PR fixes: Fixes #54

Special notes for your reviewer: -

Release note:

bugfix user 
fixes containerd-lograte unit for Flatcar images with logrotate in /usr/bin
gardener-robot commented 1 year ago

@lukasgr90 Thank you for your contribution.

gardener-robot-ci-2 commented 1 year ago

Thank you @lukasgr90 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

MrBatschner commented 1 year ago

/add reviewed/ok-to-test

BeckerMax commented 1 year ago

/ping @MrBatschner @danielfoehrKn

gardener-robot commented 1 year ago

@mrbatschner, @danielfoehrkn ℹ️ please take some time to help BeckerMax or redirect to someone else if you can't.