search

gardener / gardener-extension-os-gardenlinux

Gardener extension controller for the Garden Linux operating system
Apache License 2.0
9 stars 30 forks source link

Set `--gardenlet-uses-gardener-node-agent=true` by default #148

Closed rfranzke closed 6 months ago

rfranzke commented 6 months ago

How to categorize this PR?

/area os /kind enhancement /os garden-linux

What this PR does / why we need it: Set --gardenlet-uses-gardener-node-agent=true by default (even when UseGardenerNodeAgent is not provided via .Values.gardener.gardenlet.featureGates in the Helm chart values).

Which issue(s) this PR fixes: Part of https://github.com/gardener/gardener/issues/8023 Follow-up of https://github.com/gardener/gardener-extension-os-gardenlinux/pull/130

Special notes for your reviewer: This is a preparation step needed for removing the UseGardenerNodeAgent feature gate from gardener/gardener. Without this PR, when the feature gate is removed, it's no longer available via the .Values.gardener.gardenlet.featureGates in the Helm chart. The consequence would be that --gardenlet-uses-gardener-node-agent gets set to false. This obviously does not work with versions of gardener/gardener which no longer have the UseGardenerNodeAgent feature gate.

Release note:

It is assumed that `gardenlet`'s `UseGardenerNodeAgent` is turned on by default if the feature gate is not explicitly set. Hence, make sure to use at least Gardener `v1.82` when using this extension version.