search

gardener / gardener-extension-provider-aws

Gardener extension controller for the AWS cloud provider (https://aws.amazon.com).
https://gardener.cloud
Apache License 2.0
18 stars 96 forks source link

support extended resources without re-specifying core resources #1010

Open elankath opened 1 month ago

elankath commented 1 month ago

How to categorize this PR?

/area auto-scaling /kind enhancement /platform aws

What this PR does / why we need it:

Permit specification of custom extended resources in the worker.providerConfig.nodeTemplate without needing to explicitly re-specify core resources such as cpu, gpu, memory for the machine type again.

Which issue(s) this PR fixes: Fixes #1009

Special notes for your reviewer:

Release note:

Support specification of extended resources in provider config node template without re-specifying core resources.
elankath commented 1 month ago

@kon-angelo could you review this ? I would also like add additional unit test(s). But I need the unit test to check workerDelegate.machineClasses to see if extended resources have been set in. Unfortunately, it is un-exported field in the workerDelegate. Is it OK to introduce a method to expose this ? (Inside pkg/controller/worker/actuator.go) ?

elankath commented 1 week ago

@voelzmo this PR will be updated to latest changes and feedback next week and sent for re-review.