search

gardener / gardener-extension-provider-aws

Gardener extension controller for the AWS cloud provider (https://aws.amazon.com).
https://gardener.cloud
Apache License 2.0
19 stars 97 forks source link

Ignore `NoSuchHostedZone` on DNSRecord deletion #971

Closed Kostov6 closed 4 months ago

Kostov6 commented 5 months ago

How to categorize this PR?

/area quality /kind bug /platform aws

What this PR does / why we need it: This PR changes the actuator so that it ignores aws error code NoSuchHostedZone on DNSRecord deletion and does not report is as configuration problem. Also adding some tests.

Which issue(s) this PR fixes: Fixes https://github.com/gardener/gardener-extension-provider-aws/issues/953

Special notes for your reviewer:

Release note:

Aws error code `NoSuchHostedZone` is now ignored on DNSRecord deletion
Kostov6 commented 5 months ago

Just when adding the tests for more test coverage I was wondering if the deletion should fail with ERR_CONFIGURATION_PROBLEM if the domain name is not permitted in the zone. wdyt?

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.