search

gardener / gardener-extension-provider-azure

Gardener extension controller for the Azure cloud provider (https://azure.microsoft.com).
https://gardener.cloud
Apache License 2.0
10 stars 81 forks source link

Respect cloud configuration in dnsrecord #1018

Closed kon-angelo closed 6 days ago

kon-angelo commented 1 week ago

How to categorize this PR?

/area control-plane /kind technical-debt /platform azure

What this PR does / why we need it: Deprecate DNSRecordConfig. Gardener (and gardenlet at the moment) has no way to pass providerConfig for DNSRecords. The cloud configuration now is coming from the secret similar to how https://github.com/gardener/external-dns-management/tree/master/docs/azure-dns#using-the-service-principal-account mentions.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

Deprecate DNSRecordConfig object. Please configure the target Azure management API via the provided secret
Fix an issue where the user DNSRecord could not be created for azure-dns provider on Azure environments other than public.
kon-angelo commented 1 week ago

/test

testmachinery[bot] commented 1 week ago

Testrun: e2e-l4c7l Workflow: e2e-l4c7l-wf Phase: Succeeded

+---------------------+---------------------------+-----------+----------+
|        NAME         |           STEP            |   PHASE   | DURATION |
+---------------------+---------------------------+-----------+----------+
| infrastructure-test | infrastructure-test       | Succeeded | 28m12s   |
| infrastructure-test | infra-flow-test           | Succeeded | 26m14s   |
| infrastructure-test | infra-flow-migration-test | Succeeded | 31m14s   |
| bastion-test        | bastion-test              | Succeeded | 9m49s    |
+---------------------+---------------------------+-----------+----------+