gardener / gardener-extension-provider-equinix-metal

Gardener extension controller for the Equinix Metal cloud provider (https://equinixmetal.com/).
https://gardener.cloud
Apache License 2.0
8 stars 47 forks source link

Switch from GCR to GAR #302

Closed zkdev closed 6 months ago

zkdev commented 6 months ago

What this PR does / why we need it: Adjusts pipeline(s) to publish images and OCM-component-descriptors to Google Artifact Registry, rather than Google Container Registry.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.
zkdev commented 6 months ago

https://github.com/gardener/gardener-extension-provider-equinix-metal/commit/78e526630630bfca28b0931ae80170d2549c51f4 needs to be pushed to refs/meta/ci once this PR is merged. Cannot create PR for that due to GitHub limitations 😅

schrodit commented 6 months ago

@zkdev you have to re-generate the controller-registration due to the image change.

Can you just run make generate and push does changes to the PR?

zkdev commented 6 months ago

verify step succeeded

schrodit commented 6 months ago

@zkdev seems like still theold config is used.

but I guess the ci config needs to be merged to reflect the changes?

zkdev commented 6 months ago

but I guess the ci config needs to be merged to reflect the changes?

Yes, the required config reference is changed within this PR.

For more context: We migrated from GCR to GAR and updated configs to only be privileged for GAR uploads. As pipelines are rendered from default branch and configs are already changed (w.r.t. upload permissions), this PR verification build will never succeed.

-> It it safe to merge this PR.

schrodit commented 6 months ago

@zkdev I do not have permissions to merge the PR without passing the required checks.

@ccwienk or @rfranzke can you force merge this PR?

zkdev commented 6 months ago

head-update got green 🥳