gardener / gardener-extension-provider-equinix-metal

Gardener extension controller for the Equinix Metal cloud provider (https://equinixmetal.com/).
https://gardener.cloud
Apache License 2.0
8 stars 49 forks source link

Fix indentation in CCM ServiceMonitor #315

Closed rickardsjp closed 2 weeks ago

rickardsjp commented 4 months ago

How to categorize this PR?

/area monitoring /kind bug /platform equinix-metal

What this PR does / why we need it: The honorLabels, authorization, scheme, and tlsConfig fields are part of the Endpoint API, not the Spec. This indentation error caused the prometheus-operator to generate a scrape job configuration that specified http instead of https (because the scheme field was "missing". This in turn caused CCM-down alerts to fire because the scrape failed with a 400 error.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer: FYI: I haven't tested this in the extension setup yet. /cc @istvanballok @hendrikKahl FYI @rfranzke

Release note:

Fixes a monitoring configuration issue that caused false CCM-down alerts to fire.
RiRa12621 commented 2 weeks ago

/lgtm