search

gardener / gardener-extension-provider-openstack

Gardener extension controller for the OpenStack cloud provider (https://openstack.org).
https://gardener.cloud
Apache License 2.0
28 stars 82 forks source link

Drop floating pool name validation #62

Closed rfranzke closed 4 years ago

rfranzke commented 4 years ago

The OpenStack validator checks that the floatingPoolName used for shoots is one that was previously defined in the CloudProfile by a Gardener operator. However, some OpenStack environments don't manage the floating pools globally (at least not all of them) but sometimes also per project. Hence, such a list in the CloudProfile is never complete and we should allow end-users to enter an arbitrary floating pool name in their shoot spec. The list in the CloudProfile can still be kept and help users/the dashboard to find out default pools.

rfranzke commented 4 years ago

cc @timuthy

timuthy commented 4 years ago

This issue is also related to the LoadBalancerClasses since they belong to a FloatingPool in the CloudProfile. Hence, it makes sense to drop this validation as well, doesn't it?

rfranzke commented 4 years ago

cc @afritzler

afritzler commented 4 years ago

We can of course disable the FloatingPoolName validation but this will create a situation where users provide networks which are not reachable from the Gardener network - hence you will end up with a lot of broken clusters. I guess we could try to disable the validation for CloudProfile and ControlPlane.