gardener / gardener-extension-provider-openstack

Gardener extension controller for the OpenStack cloud provider (https://openstack.org).
https://gardener.cloud
Apache License 2.0
25 stars 81 forks source link

Allow multiple loadBalancerProviders as the default and for a region #841

Open lotharbach opened 2 weeks ago

lotharbach commented 2 weeks ago

How to categorize this PR?

/area networking /kind enhancement /platform openstack

What this PR does / why we need it: We are adding a new openstack region that uses the OVN networking stack, and also the octavia OVN loadbalancer provider that has some worthwhile advantages. But since OVN is also still missing features we want to also allow the well known amphora provider in parallel.

Currently the cloudprofile/controlplane validation does not allow multiple entries for a region.

The Shoot spec validation has always required to specify a loadBalancerProvider even when there is only a single choice, the behavior for a given shoot should stay the same, and the behavior with existing cloudprofiles should also be the same until you add multiple loadBalancerProviders.

Release note:

Allow multiple loadBalancerProviders as the default and for a region
gardener-robot commented 2 weeks ago

@lotharbach Thank you for your contribution.

gardener-robot-ci-3 commented 2 weeks ago

Thank you @lotharbach for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.