gardener / gardener-extension-provider-openstack

Gardener extension controller for the OpenStack cloud provider (https://openstack.org).
https://gardener.cloud
Apache License 2.0
28 stars 82 forks source link

Improve confusing error message #870

Closed ialidzhikov closed 1 month ago

ialidzhikov commented 1 month ago

How to categorize this PR?

/area ops-productivity /kind enhancement /platform openstack

What this PR does / why we need it: The error message

[...]: failed to create openstack seedClient: Authentication failed

is confusing. There openstack client is actually an openstack client against the Shoot's infrastructure. Maybe we wanted to express a failure creating an openstack client using a seedClient (which is a K8s client)? IMO there is no need to provide such internal details.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Release note:

NONE
kon-angelo commented 1 month ago

Thank you, more like a refactoring error