search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Adapt the TestDefinition after `vendor/` removal #160

Closed ialidzhikov closed 8 months ago

ialidzhikov commented 8 months ago

How to categorize this PR?

/kind bug

What this PR does / why we need it: I missed this in #147 . 😞

Credits to @plkokanov to noticing!

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Release note:

An issue causing the test execution command in the TestDefinition to fail is now fixed.
gardener-prow[bot] commented 8 months ago

LGTM label has been added.

Git tree hash: 5d7c9371b3139a310fd3d9511da474f8ffc55a9d

gardener-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimitar-kostadinov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [dimitar-kostadinov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dimitar-kostadinov commented 8 months ago

/cherry-pick release-v0.7

gardener-ci-robot commented 8 months ago

@dimitar-kostadinov: once the present PR merges, I will cherry-pick it on top of release-v0.7 in a new PR and assign it to you.

In response to [this](https://github.com/gardener/gardener-extension-registry-cache/pull/160#issuecomment-1970960096): >/cherry-pick release-v0.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gardener-ci-robot commented 8 months ago

@dimitar-kostadinov: new pull request created: #161

In response to [this](https://github.com/gardener/gardener-extension-registry-cache/pull/160#issuecomment-1970960096): >/cherry-pick release-v0.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.