gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Activate registry graceful shutdown #162

Closed dimitar-kostadinov closed 8 months ago

dimitar-kostadinov commented 8 months ago

How to categorize this PR?

/area robustness /kind enhancement

What this PR does / why we need it: Sets registry http.draintimeout configuration option to 25 seconds. After registry process receives SIGTERM signal, it will gracefully shuts down the server and wait 25 sec for active connections to drain.

Which issue(s) this PR fixes: Part of #3

Special notes for your reviewer:

Release note:

Registry configuration option `http.draintimeout` is set to 25 seconds to activate registry graceful shutdown.
gardener-prow[bot] commented 8 months ago

LGTM label has been added.

Git tree hash: 6cbb5a6c7147774edb63b66c03612e9e4a6257ae

gardener-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [ialidzhikov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ialidzhikov commented 8 months ago
  [FAILED] Expected success, but got an error:
      <*errors.errorString | 0xc000f8bcc0>: 
      failed to verify no running pods after hibernation: found pods in namespace shoot--local--e2e-cache-hib: [etcd-events-0]
      {
          s: "failed to verify no running pods after hibernation: found pods in namespace shoot--local--e2e-cache-hib: [etcd-events-0]",
      }
  In [It] at: /home/prow/go/src/github.com/gardener/gardener-extension-registry-cache/test/e2e/cache/create_enabled_hibernate_reconcile_delete.go:51 @ 03/05/24 18:49:40.022

Doesn't seem to be related to the registry-cache.

/test pull-gardener-extension-registry-cache-e2e-kind