search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Always delete the config cleaner MR when the extension is deleted #173

Closed ialidzhikov closed 7 months ago

ialidzhikov commented 7 months ago

How to categorize this PR?

/kind bug

What this PR does / why we need it: Similar to https://github.com/gardener/gardener-extension-shoot-rsyslog-relp/pull/80

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Release note:

Fixed an issue where the `extension-registry-configuration-cleaner` ManagedResource could block Shoot deletion if the `registry-cache` extension was disabled before the Shoot deletion was triggered, and disabling the extension failed while trying to deploy the said ManagedResource and wait for it to become ready.
gardener-prow[bot] commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

plkokanov commented 7 months ago

Awesome! /lgtm

gardener-prow[bot] commented 7 months ago

@plkokanov: changing LGTM is restricted to collaborators

In response to [this](https://github.com/gardener/gardener-extension-registry-cache/pull/173#issuecomment-2012778692): >Awesome! >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
plkokanov commented 7 months ago

Second time's the charm 🤞 /lgtm

gardener-prow[bot] commented 7 months ago

LGTM label has been added.

Git tree hash: 6ae3928bad84a759296029ae1574afda3e809436

ialidzhikov commented 7 months ago

/approve

gardener-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [ialidzhikov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment