search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

[GEP-19] Switch to the new contract of providing monitoring configuration #187

Closed ialidzhikov closed 5 months ago

ialidzhikov commented 6 months ago

How to categorize this PR?

/area monitoring /kind enhancement

What this PR does / why we need it: https://github.com/gardener/gardener/pull/9695 changes the contract of how extension can provide monitoring configuration, see https://github.com/gardener/gardener/pull/9695/files#diff-93972179f36fa195b948f0f4979acab75697f99f3c51ab889994d9d8ba9f170b. This PR adapts this extension accordingly. It also cleans up no longer needed configuration (if found).

Which issue(s) this PR fixes: Part of gardener/gardener#9065

Special notes for your reviewer: N/A

Release note:

This extension is now using the new way of providing monitoring configuration (ref [GEP-19](https://github.com/gardener/gardener/blob/master/docs/proposals/19-migrating-observability-stack-to-operators.md)) in case a shoot cluster's Prometheus has been migrated to management via `prometheus-operator`.
gardener-prow[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

rfranzke commented 6 months ago

Can we proceed with this PR?

gardener-prow[bot] commented 5 months ago

@ialidzhikov: you cannot LGTM your own PR.

In response to [this](https://github.com/gardener/gardener-extension-registry-cache/pull/187#pullrequestreview-2060859327): >/lgtm >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
gardener-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [ialidzhikov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ialidzhikov commented 5 months ago

@dimitar-kostadinov , can you lgtm?

rfranzke commented 5 months ago

/lgtm

gardener-prow[bot] commented 5 months ago

LGTM label has been added.

Git tree hash: 1f2e56faecadc1dd07e925819feb44fc11be8575