gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Introduce `remote-extension-up` make target #193

Closed dimitar-kostadinov closed 5 months ago

dimitar-kostadinov commented 6 months ago

How to categorize this PR?

/area dev-productivity /kind enhancement

What this PR does / why we need it: Introduces remote-extension-up make target to support development environment in provider-extensions setup.

Which issue(s) this PR fixes: Part of #3

Special notes for your reviewer: Depends on https://github.com/gardener/gardener/pull/9728

Release note:

The registry-cache extension does now support the [Deploying Gardener Locally and Enabling Provider-Extensions](https://github.com/gardener/gardener/blob/v1.85.1/docs/deployment/getting_started_locally_with_extensions.md) local setup.
gardener-prow[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

plkokanov commented 5 months ago

/lgtm

ialidzhikov commented 5 months ago

/assign

gardener-prow[bot] commented 5 months ago

LGTM label has been added.

Git tree hash: 0eaac6f89d2c7c37243ebe1fe3465de08cd3b0c7

gardener-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [ialidzhikov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment