gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 18 forks source link

Rework image pull check in E2E tests #196

Closed dimitar-kostadinov closed 3 months ago

dimitar-kostadinov commented 4 months ago

How to categorize this PR?

/area testing /kind test

What this PR does / why we need it: Rework the image pull check in E2E tests. The image pull check now use root pod executor and runs the following commands on the Node where the registry Pod is running:

This will allow distroless to be used as the base registry image and will solve E2E flakes caused by the missing scheduler-state.json file.

Which issue(s) this PR fixes: Part of #3

Special notes for your reviewer: N/A

Release note:

NONE
ialidzhikov commented 3 months ago

/assign

gardener-prow[bot] commented 3 months ago

LGTM label has been added.

Git tree hash: 4424b599e6dbf846c7ad59f1194bd6278be60b20

gardener-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [ialidzhikov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment