search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 18 forks source link

Use `OperatingSystemConfig` API to configure `containerd` registries and drop custom systemd unit and `registryconfigurationcleaner` daemonset #227

Closed dimitar-kostadinov closed 1 month ago

dimitar-kostadinov commented 2 months ago

How to categorize this PR?

/area robustness /kind enhancement

What this PR does / why we need it: Use the OperatingSystemConfig API to configure containerd registries and drop configure-containerd-registries.service systemd unit and registryconfigurationcleaner daemonset. ref: https://github.com/gardener/gardener/pull/10050

The gardener-node-agent handles the containerd registry configuration and adds the relevant hosts.toml files. If readiness probe is enabled in the registry configuration, hosts.toml is added when hosts are reachable.

Which issue(s) this PR fixes: Fixes #204

Special notes for your reviewer: Waiting for github.com/gardener/gardener v1.100.0 release

Release note:

The `containerd` registry configuration `hosts.toml` files are now created using the [OpetingSystemConfig CRI API](https://github.com/gardener/gardener/blob/v1.100.0/docs/extensions/operatingsystemconfig.md#cri-support).
gardener-prow[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ialidzhikov commented 1 month ago

/test all

ialidzhikov commented 1 month ago

/assign

gardener-prow[bot] commented 1 month ago

LGTM label has been added.

Git tree hash: 9f6ed509c8b5972cfa8fa9684bf46dfa71ce5312

gardener-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [ialidzhikov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment