search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Cleanup TODOs related to legacy monitoring configuration #237

Closed dimitar-kostadinov closed 2 months ago

dimitar-kostadinov commented 2 months ago

How to categorize this PR?

/area monitoring /kind cleanup

What this PR does / why we need it: Cleanup TODOs related to legacy monitoring configuration. ref: #187

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer: N/A

Release note:

The legacy method of providing monitoring configuration via `ConfigMap`s labeled with `extensions.gardener.cloud/configuration=monitoring` has been removed. The extension does now only uses the [new contract](https://github.com/gardener/gardener/blob/v1.101.1/docs/extensions/logging-and-monitoring.md#monitoring) for providing monitoring configuration. Before upgrading to this version of the extension, make sure that the deployed Gardener version supports the [new monitoring contract](https://github.com/gardener/gardener/blob/v1.101.1/docs/extensions/logging-and-monitoring.md#monitoring).
ialidzhikov commented 2 months ago

/assign

gardener-prow[bot] commented 2 months ago

LGTM label has been added.

Git tree hash: 2ccd593776a9adafdfd974e33424af8ef23d052f

gardener-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [ialidzhikov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment