search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Configure TLS communication between registry cache and containerd #245

Open dimitar-kostadinov opened 2 months ago

dimitar-kostadinov commented 2 months ago

How to categorize this PR?

/area security /kind enhancement

What this PR does / why we need it: Configure TLS communication between registry cache and containerd.

Which issue(s) this PR fixes: Fixes #203

Special notes for your reviewer:

Release note:

TBD
gardener-prow[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

gardener-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from dimitar-kostadinov. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ialidzhikov commented 2 months ago

/assign

gardener-ci-robot commented 1 month ago

The Gardener project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:

You can:

/lifecycle stale

ialidzhikov commented 1 month ago

/remove-lifecycle stale

gardener-prow[bot] commented 1 day ago

@dimitar-kostadinov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-extension-registry-cache-e2e-kind b8a104e7df28291fd38c5b88389435049056e706 link true /test pull-gardener-extension-registry-cache-e2e-kind

Full PR test history. Your PR dashboard. Command help for this repository. Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ialidzhikov commented 22 hours ago

The reason for the failing e2e-cache-ssc e2e test is described in https://github.com/gardener/gardener/issues/10810.

/hold until the corresponding issue is resolved