search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Replace use of `public.ecr.aws/nginx/nginx` with `ghcr.io/jitesoft/alpine` image #254

Closed dimitar-kostadinov closed 2 months ago

dimitar-kostadinov commented 2 months ago

How to categorize this PR?

/area testing /kind flake

What this PR does / why we need it: There is an issue when distribution/distribution is used as a pull-through cache to Amazon Public ECR Gallery. Sometimes image manifests are successfully cached, but download of image layers blobs fails with Internal Server Error - 500.

With this PR public.ecr.aws/nginx/nginx image is replaced with ghcr.io/jitesoft/alpine. The VerifyRegistryCache func is extended to support various images.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Release note:

e2e tests are no longer using test images from public ECR as the Distribution project cannot pull blobs from it.
ialidzhikov commented 2 months ago

/assign

gardener-prow[bot] commented 2 months ago

LGTM label has been added.

Git tree hash: 1028183232c885ec9735ef4c0d50fdce33ef4d1d

gardener-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [ialidzhikov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment