search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Document that the image pull Secrets should not be removed when using registry cache with credentials #260

Closed ialidzhikov closed 1 month ago

ialidzhikov commented 1 month ago

How to categorize this PR?

/area documentation /kind enhancement

What this PR does / why we need it: See https://github.com/gardener/gardener-extension-registry-cache/issues/256#issuecomment-2358528858

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Release note:

NONE
gardener-prow[bot] commented 1 month ago

LGTM label has been added.

Git tree hash: 60be9987239d7e219de1421cef816b02bfa5439b

gardener-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimitar-kostadinov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [dimitar-kostadinov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment