search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Delete the monitoring resources on Extension deletion #268

Closed ialidzhikov closed 2 weeks ago

ialidzhikov commented 2 weeks ago

How to categorize this PR?

/area monitoring /kind bug

What this PR does / why we need it: Right now the monitoring resources (dashboards ConfigMap, PrometheusRule, ScrapeConfig) are not deleted on Extension deletion.

Which issue(s) this PR fixes: Follow-up after https://github.com/gardener/gardener-extension-registry-cache/pull/187

Special notes for your reviewer: N/A

Release note:

The monitoring resources (dashboards ConfigMap, PrometheusRule, ScrapeConfig) are now deleted when the Extension is deleted.
gardener-prow[bot] commented 2 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

gardener-prow[bot] commented 2 weeks ago

LGTM label has been added.

Git tree hash: 1a076aba029db17ba41b2387c7ba403114e8512e

gardener-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimitar-kostadinov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [dimitar-kostadinov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment