search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Fix `make extension-up` #277

Closed ialidzhikov closed 2 weeks ago

ialidzhikov commented 3 weeks ago

How to categorize this PR?

/area dev-productivity /kind bug

What this PR does / why we need it: See more details in https://github.com/gardener/gardener-extension-registry-cache/issues/276 and in the comment in the skaffold.yaml file.

Which issue(s) this PR fixes: Fixes https://github.com/gardener/gardener-extension-registry-cache/issues/276

Special notes for your reviewer: N/A

Release note:

An issue causing `make extension-up` to fail to patch the ControllerDeployment is now mitigated.
gardener-prow[bot] commented 2 weeks ago

LGTM label has been added.

Git tree hash: 4dd7704b1899fb808350261038ec090d9fce9de6

gardener-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimitar-kostadinov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [dimitar-kostadinov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ialidzhikov commented 2 weeks ago

The test execution was successful but the test timed out:

{"component":"entrypoint","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:169","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 1h0m0s timeout","severity":"error","time":"2024-11-05T11:14:15Z"}

With https://github.com/gardener/gardener-extension-registry-cache/pull/280 we will address this issue.

ialidzhikov commented 2 weeks ago

/test pull-gardener-extension-registry-cache-e2e-kind

dimitar-kostadinov commented 2 weeks ago 
{"level":"error","ts":"2024-11-06T11:09:36.230Z","logger":"test","msg":"Failed creating shoot","shoot":{"name":"e2e-cache-ssc","namespace":"garden-local"},"error":"retry failed with context deadline exceeded, last error: shoot \"e2e-cache-ssc\" was not successfully reconciled","stacktrace":"github.com/gardener/gardener/test/framework.(*ShootCreationFramework).CreateShootAndWaitForCreation\n\t/home/prow/go/pkg/mod/github.com/gardener/gardener@v1.107.0/test/framework/shootcreationframework.go:380\ngithub.com/gardener/gardener-extension-registry-cache/test/e2e/cache.init.func3.1\n\t/home/prow/go/src/github.com/gardener/gardener-extension-registry-cache/test/e2e/cache/create_enabled_delete_shoot_system_components.go:40\ngithub.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3\n\t/home/prow/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.21.0/internal/node.go:472\ngithub.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3\n\t/home/prow/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.21.0/internal/suite.go:894"}

/test pull-gardener-extension-registry-cache-e2e-kind