gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

`make extension-up` does not generate a new tag on code changes locally #278

Closed ialidzhikov closed 2 weeks ago

ialidzhikov commented 2 weeks ago

How to categorize this issue?

/area dev-productivity /kind bug

What happened: make extension-up generates always a tag in the format v0.11.0-8-g4f9a9ed3.

This is the output of the git describe --tags --always command: ref https://github.com/GoogleContainerTools/skaffold/blob/6293a3efe10fc12ccb16c2477e59aa4b9335a8dc/pkg/skaffold/tag/git_commit.go#L109-L111

Demystifying v0.11.0-8-g4f9a9ed3:

The tag does no change when doing changes locally without commits. make extension-up runs build a new image but tag it with the same tag. Running update is not triggered for the extension Pods as the tag didn't change.

Upstream docs for taggers: ref https://skaffold.dev/docs/taggers/.

What you expected to happen: Code changes locally to generate a new tag and ControllerDeployment to be updated with a new tag.

How to reproduce it (as minimally and precisely as possible): See above.

Anything else we need to know?: Many thanks to @rrhubenov for helping analysing this issue.

Environment: