gardener / gardener-extension-shoot-cert-service

Gardener extension controller for certificate services for shoot clusters.
https://gardener.cloud
Apache License 2.0
10 stars 37 forks source link

Switch VPA's API version to `autoscaling.k8s.io/v1` #284

Closed ialidzhikov closed 3 months ago

ialidzhikov commented 3 months ago

How to categorize this PR?

/area auto-scaling /kind bug

What this PR does / why we need it: Right now, shoot-cert-management-seed-vpa specifies controlledValues: RequestsOnly https://github.com/gardener/gardener-extension-shoot-cert-service/blob/dca9a34a7feeee4790614d3292de29958283b088/charts/internal/shoot-cert-management-seed/templates/vpa.yaml#L17 but this change does not really get applied because the used API version is autoscaling.k8s.io/v1beta2 and not autoscaling.k8s.io/v1. The controlledValues field is introduced in API version autoscaling.k8s.io/v1.

Which issue(s) this PR fixes: N/A but prevents OOMKills due to the controlledValues field not being set and usage of the default behaviour of scaling RequestsAndLimits proportionally.

Special notes for your reviewer: N/A

Release note:

An issue causing the `controlledValues: RequestsOnly` field not to be set for the `shoot-cert-management-seed-vpa` VPA is now fixed.