gardener / gardener-extension-shoot-cert-service

Gardener extension controller for certificate services for shoot clusters.
https://gardener.cloud
Apache License 2.0
10 stars 37 forks source link

Remove memory limit from the cert-controller-manager Deployment #286

Closed ialidzhikov closed 3 months ago

ialidzhikov commented 3 months ago

How to categorize this PR?

/area auto-scaling /kind bug

What this PR does / why we need it: With https://github.com/gardener/gardener-extension-shoot-cert-service/pull/284 we make VPA to scale requests only and no longer to scale limits proportionally. However, with this the configured memory limit of 600Mi can lead to OOMKills for some Pods. Following https://github.com/gardener/gardener/blob/master/docs/usage/shoot_pod_autoscaling_best_practices.md, this PR removes the memory limit.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Release note:

The memory limit from the `cert-controller-manager` Deployment is now removed.