search

gardener / gardener-extension-shoot-dns-service

Gardener extension controller for DNS services for shoot clusters.
https://gardener.cloud
Apache License 2.0
8 stars 34 forks source link

Add copy of images.yaml to charts dir to resolve RBSC issue #237

Closed MartinWeindel closed 1 year ago

MartinWeindel commented 1 year ago

How to categorize this PR?

/area delivery /kind bug

What this PR does / why we need it: Only the charts folder is available for landscape setup for landscapes synced by RBSC. As images.yaml is read during installation via landscape setup, it must be available in the charts folder, too.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

Add copy of images.yaml to charts dir to resolve installation issue for landscapes using RBSC
MartinWeindel commented 1 year ago

Would it not be better to link both images.yaml so that we only need to update one of them?

I first started with that, but I think it is too risky as I don't know how both the set_dependency_version script and the RBSC sync are working in detail, i.e. if they deal correctly with links on updating and copying. The images.yaml is only updated by the set_dependency_version script normally. As the script writes both files they should be kept in sync automatically.