search

gardener / gardener-extension-shoot-dns-service

Gardener extension controller for DNS services for shoot clusters.
https://gardener.cloud
Apache License 2.0
8 stars 35 forks source link

Add shoot.gardener.cloud/no-cleanup=true label to CRDs #243

Closed MartinWeindel closed 1 year ago

MartinWeindel commented 1 year ago

How to categorize this PR?

/area usability /kind bug

What this PR does / why we need it: Add shoot.gardener.cloud/no-cleanup=true label to CRDs to avoid Gardenlet to delete CRDs and GRM recreating them. As DNSEntries are replicated to the control plane, it is not mandatory to delete them (or their source objects) in the shoot cluster. Additionally reverts https://github.com/gardener/gardener-extension-shoot-dns-service/pull/240 as not needed anymore.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

The `CustomResourceDefinition`s deployed to shoot clusters are now labelled with `shoot.gardener.cloud/no-cleanup=true` to prevent `gardenlet` to deleting them during shoot deletion.
MartinWeindel commented 1 year ago

/cc @ScheererJ