search

gardener / gardener-extension-shoot-dns-service

Gardener extension controller for DNS services for shoot clusters.
https://gardener.cloud
Apache License 2.0
8 stars 34 forks source link

Don't skip validation for missing provider secret resources if `spec.resources` is undefined in shoot manifest #320

Closed MartinWeindel closed 5 months ago

MartinWeindel commented 5 months ago

How to categorize this PR?

/area control-plane /kind bug

What this PR does / why we need it: If the shoot manifest has no section spec.resources, the validating admission webhook should not silently ignore that DNS provider secrets must be specified in the resources section.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

Don't skip validation for missing provider secret resources if `spec.resources` is undefined in shoot manifest
ScheererJ commented 5 months ago

/cla

gardener-robot commented 5 months ago

@ScheererJ I reached out successfully to the cla-assistant to recheck this pull request.