search

gardener / gardener-extension-shoot-rsyslog-relp

Other
0 stars 15 forks source link

Adds missing empty new line at end of audit rules file #150

Closed plkokanov closed 3 months ago

plkokanov commented 3 months ago

How to categorize this PR?

/kind bug

What this PR does / why we need it: This PR adds a new line at the end of https://github.com/gardener/gardener-extension-shoot-rsyslog-relp/blob/main/pkg/webhook/operatingsystemconfig/testdata/11-privileged-special.rules Generally, separate rule files should always end with a new line, otherwise they are not merged together properly by augenrules --load.

This will be properly tested by a tm test added in #149

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

Fixed an issue that caused the `-a exit,always -F arch=b64 -S mount_setattr -F auid!=-1 -F key=privileged_special` audit rule to not get correctly applied.
plkokanov commented 3 months ago

/assign @Kostov6

/cherry-pick release-v0.5

gardener-ci-robot commented 3 months ago

@plkokanov: once the present PR merges, I will cherry-pick it on top of release-v0.5 in a new PR and assign it to you.

In response to [this](https://github.com/gardener/gardener-extension-shoot-rsyslog-relp/pull/150#issuecomment-2259938761): >/assign @Kostov6 > >/cherry-pick release-v0.5 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
gardener-prow[bot] commented 3 months ago

LGTM label has been added.

Git tree hash: 0a9a24c7c18b84839753d44dfb2cdd46e85f4723

plkokanov commented 3 months ago

/approve

gardener-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, plkokanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-shoot-rsyslog-relp/blob/main/OWNERS)~~ [plkokanov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gardener-ci-robot commented 3 months ago

@plkokanov: new pull request created: #151

In response to [this](https://github.com/gardener/gardener-extension-shoot-rsyslog-relp/pull/150#issuecomment-2259938761): >/assign @Kostov6 > >/cherry-pick release-v0.5 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.