search

gardener / gardener-extension-shoot-rsyslog-relp

Other
0 stars 15 forks source link

Fix local setup issues #194

Closed ialidzhikov closed 1 day ago

ialidzhikov commented 2 weeks ago

How to categorize this PR?

/area dev-productivity /kind bug

What this PR does / why we need it: This PR performs the following changes from the registry-cache extension which are applicable also to this extension:

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Release note:

An issue causing `make extension-up` to fail to patch the ControllerDeployment is now mitigated.
An issue causing `make extension-up` to do NOT generate a new tag for local source code changes is now fixed.
plkokanov commented 1 day ago

/lgtm /approve

gardener-prow[bot] commented 1 day ago

LGTM label has been added.

Git tree hash: 75f363104025bd0734d939cbaf63862d6aad3bcb

gardener-prow[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: plkokanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-shoot-rsyslog-relp/blob/main/OWNERS)~~ [plkokanov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment