search

gardener / gardener

Homogeneous Kubernetes clusters at scale on any infrastructure using hosted control planes.
https://gardener.cloud
Apache License 2.0
2.87k stars 473 forks source link

gardenlet config resource has unnecessary pointer fields #10378

Open Kostov6 opened 3 weeks ago

Kostov6 commented 3 weeks ago

How to categorize this issue?

/area quality /kind enhancement

What would you like to be added: It seems a lot of fields from pkg/gardenlet/apis/config/types.go are needlessly pointers that are set to empty structures by default. Example: https://github.com/gardener/gardener/blob/a9d81c0dc2c2ae5c9ca3e3919b5af8f1c218106f/pkg/gardenlet/apis/config/v1alpha1/defaults.go#L131-L180

Lets make them to objects instead of pointers

Kostov6 commented 3 weeks ago

/assign Kostov6 /good-first-issue

gardener-prow[bot] commented 3 weeks ago

@Kostov6: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/gardener/gardener/issues/10378): >/assign Kostov6 >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.