search

gardener / kupid

Inject scheduling criteria into target pods orthogonally by policy definition.
Apache License 2.0
11 stars 19 forks source link

Fix metrics port in service #52

Closed shreyas-s-rao closed 1 year ago

shreyas-s-rao commented 1 year ago

What this PR does / why we need it: This PR fixes the metrics port in the service chart, which was previously misconfigured due to a possible copy-paste error upon repo creation. The error was never caught till now because the service seems unused for scraping metrics. /kind bug

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer: /invite @ashwani2k /cc @rfranzke since this might require a change in https://github.com/gardener/kupid/pull/50 to accommodate the metrics port as well.

Release note:

Fix metrics port in service chart.
rfranzke commented 1 year ago

Without the prometheus labels, kupid will not be scraped anyways. But sure, let's fix this and get this in.

shreyas-s-rao commented 1 year ago

@rfranzke I've added the prometheus annotations as discussed in an out-of-band chat, and also made some other minor changes. PTAL, thanks!