search

gardener / landscaper

Development of Landscaper - A deployer for K8S workloads with integrated data flow engine.
Apache License 2.0
56 stars 34 forks source link

Fix helm log function #1193

Closed robertgraeff closed 1 month ago

robertgraeff commented 1 month ago

What this PR does / why we need it:

This PR fixes how the helm log function fills a list of values into a format string. The first placeholder of the format string was filled with the complete value list, instead of only the first value. All other placeholder did not get a value. As a result, the log messages looked for example like this:

"beginning wait for [16 598623897521] resources with timeout of %!v(MISSING)"

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

- Fix helm log function
achimweigel commented 1 month ago

@robertgraeff are you sure that this is required? If you look at my change before, the call was exactly the same?

I just got it. This is the reason why we often see these strange log messages from helm. Got it. :-)