search

gardener / landscaper

Development of Landscaper - A deployer for K8S workloads with integrated data flow engine.
Apache License 2.0
56 stars 34 forks source link

Optimize boolean flags in config #211

Closed Diaphteiros closed 1 year ago

Diaphteiros commented 3 years ago

How to categorize this issue?

/area TODO /kind enhancement /priority 4

What would you like to be added: See https://github.com/gardener/landscaper/pull/185#discussion_r641541535 for context.

Having disable flags in the config is somewhat unintuitive, as setting them to true actually deactivates something instead of activating it. However, with golang defaulting booleans to false, changing the disable flag to an enable flag while keeping the current defaults requires pointers, as otherwise setting the flag to false and not setting it at all will be indistinguishable in the code.

gardener-robot commented 3 years ago

@Diaphteiros Label area/todo does not exist.

achimweigel commented 1 year ago

@In-Ko closed because outdated and/or copied into internal project