search

gardener / landscaper

Development of Landscaper - A deployer for K8S workloads with integrated data flow engine.
Apache License 2.0
56 stars 34 forks source link

CustomReadinessCheck for Helm Deployer not working #600

Open enrico-kaack-comp opened 2 years ago

enrico-kaack-comp commented 2 years ago

How to categorize this issue?

/area helm-deployer /kind bug /priority 3

What happened: Using a custom readiness check with the real helm deployers does not work. It always succeed.

How to reproduce it (as minimally and precisely as possible): use a simple helm chart and add a readiness check. Set ProviderConfiguration.HelmDeployment to true.

Anything else we need to know?: The Custom ReadinessCheck seems to report success in this early exit: https://github.com/gardener/landscaper/blob/master/pkg/deployer/lib/readinesscheck/customreadinesscheck.go#L44

len(c.ManagedResources) == 0 is true, it seems the ManagedResources are not correctly tracked by the real helm deployer.

Environment:

achimweigel commented 1 year ago

@enrico-kaack-comp could this issue be closed?